-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #9892: Add span when translating with
to an and type
#9953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
I believe the best place to add a test here is to add |
Added the test. |
with
to an and typewith
to an and type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tgodzik !
Apparently the latest changes cause several other failures. It seems that the offset of other errors in the files are displaced. Perhaps the latest changes cause an overall displacement of all the offsets in the file? |
Maybe try with the version that @sjrd proposed |
@nicolasstucki position changes at |
Thank you @tgodzik |
Fix #9892
Without adding the span it is thought to be synthetic, which causes scalaJS to throw an error.